Hook Updates

IAirlockBase has a postClaimHandlerWhitelist set which includes the whitelisted postClaim handlers added by the trusted role.

However, when _withdrawToBeneficary is called, it's not checked that the handler is whitelisted. This allows anyone to bypass the postClaim handlers by setting their own contract as the handler and effectively perform direct claims even if they are disallowed.

Before claiming, ensure the postClaimHandler is whitelisted. In addition, consider if the extraData passed should also be validated.

withdraw(string calldata _id, uint256 _requestedWithdrawalAmount) calls withdraw(string calldata _id, uint256 _requestedWithdrawalAmount, IPostClaimHandler postClaimHandler, bytes memory extraData) with postClaimHandler hardcoded to address 0.

If DIRECT_CLAIM_ALLOWED has not been added to postClaimHandlerWhitelist, this will cause a revert inside of _withdrawToBeneficiary.

Document to users that they must call the proper withdraw() function when DIRECT_CLAIM_ALLOWED is not allowed.

The errors ClaimHandlerAlreadyWhitlested and ClaimHandlerNotYetWhitlested should be corrected to ClaimHandlerAlreadyWhitelisted and ClaimHandlerNotYetWhitelisted respectively.

Correct the typos according to the above.

IAirlockBase.getPostClaimHandlers() will return an array which includes address(0) when direct claim is enabled. Having this value in the array may be unexpected for third parties integrating with the contracts. For example, they may be calling some function on each handler. Then they will call it on address(0) and the tx will revert.

Make sure to document this behavior

The changed withdraw functions don't include the postClaimHandler and extraData parameters in their NatSpecs.

Add these two parameter to the NatSpecs.

postClaimHandlers is a memory array that uses postClaimHandlerWhitelist.length() to set the length of the array. However, on the previous line, the size is already stored as a stack variable. It is cheaper to use that variable than to call postClaimHandlerWhitelist.length().

Use arrLength to set the size of the array for postClaimHandlers.

The comment “@dev if direct claim feature is disabled, then this method should not be called” was added for the withdraw function with a postClaimHandler parameter rather than the withdraw function defaulting the handler to address(0).

Place the comment for function withdraw(string calldata _id, uint256 _withdrawalAmount) external virtual; instead.

Both Calendar and Interval allocations use the same feeAlreadyPayed mapping. If a Calendar and Interval have the same allocation id’s, the fee paid would potentially be set and a claim fee would not be paid for the allocation.

Ensure allocation ID’s are unique.