Guardian's review of Amount Updates for Magna, published November 2024. The report records 2 findings, including 2 low.
- Published
- Review window
- November 15 to 17, 2024
- Language
- Solidity
- Chains
- Ethereum, Base, Optimism, Polygon, Arbitrum, BNB Chain
- Sector
- Infrastructure
- 0 Critical
- 0 High
- 0 Medium
- 2 Low
- 0 Informational
Findings 2
-
L-01 Low Validate Schedule Ordering Warning Resolved
Description
To properly calculate the vested amount for Interval and Calendar schedules, the piece end times and unlock timestamps must be in ascending order respectively. If this was not the case, the user would not be able to withdraw the expected vested amount as the loops would break early.
Recommendation
Ensure there is off-chain validation that the Interval schedule’s pieces are sorted by end time in ascending order and that Calendar schedule’s unlock timestamps are sorted in ascending order.
-
L-02 Low Immutable feeSetter Can Be Misleading Documentation Acknowledged
Description
feeSetterin MerkleVester is immutable and its value is assigned in the constructor. However theBENEFACTORcan grant/revoke roles from/to addresses because it has aDEFAULT_ADMIN_ROLE.Hence with role granting and revoking, in any point in time, the immutable
feeSetteraddress may not have the ability to set the fee while some other addresses do.Recommendation
Document this behaviour to prevent unexpected scenarios and wrong expectations.
No findings match.
More from Magna
All 9 reportsPut your code through the same review.
This review started with a conversation about scope. Tell us what you are building and we will plan yours with you.