USD8

In the claimYield function the hasRole check has been replaced with sl which does not compile.

Correct the typo.

MYieldToOne.setYieldRecipient() unconditionally calls claimYield() before updating the recipient. USD8’s claimYield reverts if currentYield == 0 and also reverts when fee > 0 but protocolFeeAmount rounds to 0 (dust), and it is additionally blocked when paused. This means setYieldRecipient will revert under common conditions (no yield yet, small yield, or paused), preventing administrators from changing the yield destination.

Consider refactoring this flow to early return in these cases instead of reverting to allow this configuration to occur.

In the NatSpec for the initialize function there is no NatSpec for the forcedTransferManager parameter.

Update the NatSpec for the initialize function to include the forcedTransferManager parameter.

In the 4th scenario in the claimYield function the protocolFeeAmount is computed using round down division, rounding against the protocol and in favor of the yieldRecipient.

This however poses almost no impact since the claimYield function is permissioned to be callable only by the admin or the YIELD_RECIPIENT_MANAGER_ROLE and normal usage will only truncate a handful of wei in favor of the yield recipient over the protocol recipient over time.

Be aware that the existing protocol fee logic rounds against the protocol and in favor of the yield recipient. If desired, consider using round up logic for the protocol fee amount, however keeping the code unchanged and using division by truncation, while acknowledging this behavior, is more straightforward.

In the USD8 contract the _beforeClaimYield function is unnecessarily overridden to add the onlyRole(YIELD_RECIPIENT_MANAGER_ROLE) modifier, however the entire claimYield function has been overridden in the USD8 contract, which entirely bypasses this _beforeClaimYield hook.

Either invoke the _beforeClaimYield hook instead of the authorization that is performed at the beginning of the claimYield function, or remove the _beforeClaimYield override entirely.

In the NatSpec for the _beforeClaimYield function it is mentioned that Addresses with the YIELD_RECIPIENT_MANAGER_ROLE are still able to claim yield when the contract is paused.

However the entire claimYield function has been overridden and uses a whenNotPaused modifier, thus contradicting this comment.

Clarify what the desired behavior is and if it is desired that certain roles can claim yield even when the system is paused consider removing the whenNotPaused modifier.

Typically the initialize function handles the entire initialization of a contract that is necessary. However the initialize function for the USD8 contract does not instantiate an initial protocol treasury address and therefore a treasury must always be set with the setProtocolTreasuryAddress function before yield can be claimed.

Confirm if this secondary initialization step is desired, if not consider including an initial treasury address in the initialize function.

claimYield mints tokens to the yieldRecipient and protocolTreasuryAddress without checking if these accounts are frozen.

This bypasses the freeze policy applied to wrap/unwrap/transfers and can accumulate balances on frozen accounts, undermining the intent that operations are blocked for frozen addresses.

This is likely acceptable given the trusted nature of these addresses and the claimYield function. However be aware of this circumvention of the freeze list.

In the base MYieldToOne contract there is an initialize function which has different parameters and therefore a different function signature than the initialize function declared in the USD8 contract.

As a result, there are multiple initialize functions with the initializer modifier available to be called on the USD8 contract. This poses a risk if the wrong initialize function is called, incorrectly initializing the proxy and disabling all other initializers.

When deploying the USD8 contract ensure that the initialize function that is implemented on the USD8 contract is the one being invoked based upon the parameters being provided.

Throughout the USD8 contract in the documentation for the initialize, _beforeWrap, _beforeUnwrap functions mUSD is referenced instead of USD8.

Consider updating the comments to refer to USD8 instead of mUSD.