Synthetics V2, Review 7

When estimating the gas needed for a decrease order in estimateExecuteDecreaseOrderGasLimit, 1 is added to gasPerSwap instead of adding 1 to the swap length to account for the extra swap due to decreasePositionSwapType.

Add 1 to the order’s swap length rather than the gasPerSwap.

GMX Team: The recommendation will be implemented in a future release.

During both increase and decrease orders, forPositiveImpact is determined based upon the priceImpactUsd being greater than 0, however this is based on the priceImpactUsd after it has been capped. In the event that the position impact pool is empty and the positive price impact value is capped to 0, the fees will be calculated with a forPositiveImpact of false, meanwhile the action does indeed balance the pool.

Compute forPositiveImpact before the price impact is capped so that actions that balance the pool receive the corresponding configured fees.

GMX Team: The recommendation will be implemented in a future release.

The price impact logic is split into two if cases where the first one accounts for positive price impact and the second accounts for negative price impact. If the first _params.priceImpactUsd > 0 condition is met, the second _params.priceImpactUsd < 0 condition cannot be met, however this condition is still subsequently checked.

Use an else if (_params.priceImpactUsd < 0) condition to avoid checking if the priceImpactUsd is negative if it was already found to be positive.

GMX Team: Acknowledged.

The NatSpec does not match the struct parameters. Missing parameters include:

• info
• minBlockConfirmations
• maxRefPriceDeviationFactor
• validatedPrices

Update the NatSpec to reflect the struct accurately.

GMX Team: NatSpec will be updated in a future release.

“[t]he difference would be in the stored as a…” should be edited to “the difference would be stored as”.

Edit the comment described above.

GMX Team: The typo will be fixed in a future release.