Skip to content
$1,000,000 in security audit grants are live now, Apply here →
Get a quote

Security review · January 2024

Config

for GMX

GMX engaged Guardian to review the security of its Config file updates. From the 12th of January to the 16th of January a team of 2 auditors reviewed the source code in scope.

Get a quote Read the full report
Published
Review window
January 12 to 16, 2024
Language
Solidity
Chains
Arbitrum, Avalanche
Sector
Perpetuals
  • 0 Critical
  • 0 High
  • 0 Medium
  • 2 Low
  • 0 Informational

2 pending

Scope

Overview

GMX engaged Guardian to review the security of its Config file updates. From the 12th of January to the 16th of January a team of 2 auditors reviewed the source code in scope.

Findings 2

  1. CON-1 Low onlyKeeper Not Implemented In The RoleModule Optimization Pending
    Location
    Config.sol: 48

    Description

    The onlyKeeper modifier is implemented directly in the Config contract, however it would uphold separation of concerns and deduplicate code if it were implemented in the RoleModule contract.

    Recommendation

    Consider moving the onlyKeeper implementation to the RoleModule contract and utilizing the _validateRole function to deduplicate code.

    Link to CON-1
  2. CON-2 Low Limited Keepers Cannot Set Gas Multipliers Optimization Pending
    Location
    Config.sol: 410-411

    Description

    Limited keepers are able to configure the ESTIMATED_GAS_FEE_BASE_AMOUNT and EXECUTION_GAS_FEE_BASE_AMOUNT.

    However, they are unable to configure the ESTIMATED_GAS_FEE_MULTIPLIER_FACTOR and EXECUTION_GAS_FEE_MULTIPLIER_FACTOR.

    Recommendation

    Consider whether the limited keepers should be allowed to configure the gas multipliers.

    Link to CON-2

More from GMX

All 44 reports

  1. Timelock Updates

     4 findings 4 findings: 3 low, 1 informational

  2. LayerZeroProvider Routing

     1 finding 1 finding: 1 medium

  3. Open Interest Updates

     5 findings 5 findings: 2 medium, 3 low

  4. Updates Branch

     2 findings 2 findings: 2 low

Put your code through the same review.

This review started with a conversation about scope. Tell us what you are building and we will plan yours with you.

Get a quote