EthenaLock

The NatSpec for ZeroAddress incorrectly states that it is raised when the constructor receives a zero admin_ address. That condition actually raises the inherited OwnableInvalidOwner error.

ZeroAddress is used when the ENA token address, the wallet passed to sunsetRelease, or the recipient passed to rescue is zero.

This mismatch can mislead integrators relying on generated documentation to identify and handle reverts.

Update the NatSpec to describe the actual conditions that raise ZeroAddress.

Ethena Team: Fixed in 757f2d1

The EthenaLock documentation states:

A shortfall of even 1 wei freezes every position permanently, with no owner lever

However, _assertSolvent compares the current token balance against totalLockedAll. Anyone can transfer tokens directly to the contract without increasing totalLockedAll or creating a position. Once the transfer covers the shortfall, matured withdrawals can succeed again, assuming normal token transfers.

This description could mislead operators during incident response, causing them to overlook a valid recovery path and treat recoverable funds as permanently inaccessible.

Update the documentation to explain that withdrawals remain blocked while the contract is insolvent and that direct token transfers sufficient to cover the deficit can restore solvency.

Ethena Team: Fixed in f30e52e

BelowMinLock and AmountOverflow name their first argument received, but the reported value does not always represent tokens received during a deposit.

BelowMinLock can report the requested deposit amount, the actual amount received, or the remaining locked balance after a withdrawal. AmountOverflow reports the total position balance after adding the deposit.

These misleading names may cause integrators to misinterpret decoded revert data.

Consider renaming the argument to amount in BelowMinLock and positionAmount in AmountOverflow.

Ethena Team: Fixed in e1a12ef