Skip to content
$1,000,000 in security audit grants are live now, Apply here →

Security review · January 2025

USD0 Pyth Oracle

for Abracadabra Money

Guardian's review of USD0 Pyth Oracle for Abracadabra Money, published January 2025. The report records 2 findings, including 2 low.

Published
Review window
December 31, 2024 to January 6, 2025
Language
Solidity
Chains
Ethereum
Sector
Lending, Stablecoins
  • 0 Critical
  • 0 High
  • 0 Medium
  • 2 Low
  • 0 Informational

2 pending

Findings 2

  1. L-01 Low Unnecessary USD0PP_DECIMALS Variable Gaming Pending
    Location
    Global

    Description

    The USD0PP_DECIMALS variable in the script/MagicUSD0ppOracle.s.sol file is unnecessary as it is unused.

    Recommendation

    Remove the USD0PP_DECIMALS variable.

  2. L-02 Low Pyth Confidence Intervals Are Not Considered Best Practices Pending

    Description

    Pyth prices offer a confidence interval range for every price, this is because the exact price of an asset cannot be given due to difference across exchanges and reporting sources, especially during times of volatility. Pyth recommends that the confidence interval be used in two ways, which could be adapted to the use-case for the USD0 Cauldron system:

    1. Opt to not use the Pyth price if the confidence range becomes too wide, as this is an indication of uncertain pricing which may lead to profitable arbitrage opportunities.
    2. Apply the confidence range returned from Pyth as a spread, moving in the direction that would be disadvantageous for traders.

    Recommendation

    Consider adopting one or both of these use-cases for the pyth confidence interval to provide protection for uncertain pricing results.

More from Abracadabra Money

All 19 reports
  1. MagicGLP Upgrade

    11 findings1 high 11 findings: 1 high, 10 low
  2. PurrSwap Aerodrome

    105 findings9 high 105 findings: 9 high, 23 medium, 45 low, 28 informational
  3. PurrSwap ve33

    74 findings5 critical · 10 high 74 findings: 5 critical, 10 high, 20 medium, 39 low
  4. Hyperliquid OFT Deployment

    3 findings 3 findings: 1 low, 2 informational

Put your code through the same review.

This review started with a conversation about scope. Tell us what you are building and we will plan yours with you.

Get a quote